[
https://issues.apache.org/jira/browse/YARN-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675817#comment-16675817
]
Íñigo Goiri commented on YARN-8972:
-----------------------------------
Thanks [~giovanni.fumarola] for [^YARN-8972.v1.patch].
A few comments:
* We can fix the checkstyles.
* What's the story behind the old
{{test/java/org/apache/hadoop/yarn/server/router/clientrm/PassThroughClientRequestInterceptor.java}}?
It still looks like a mock but now is in main.
* Do you need to document this new option in yarn-default.xml or some other
documentation?
* The javadoc for {{RouterServerUtil#checkAppSubmissionContext}} is confusing
because the name of the method is generic. In general, the prevention of DoS is
understood as many requests, I would put that as a comment inside the method.
* There are a bunch of code commented in logContainerLaunchContext.
* The style of the break lines is correct in
ApplicationSubmissionContextInterceptor#submitApplication but is hard to read.
Maybe extracting the variable would make it easier.
> [Router] Add support to prevent DoS attack over ApplicationSubmissionContext
> size
> ---------------------------------------------------------------------------------
>
> Key: YARN-8972
> URL: https://issues.apache.org/jira/browse/YARN-8972
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Giovanni Matteo Fumarola
> Assignee: Giovanni Matteo Fumarola
> Priority: Major
> Attachments: YARN-8972.v1.patch
>
>
> This jira tracks the effort to add a new interceptor in the Router to prevent
> user to submit applications with oversized ASC.
> This avoid YARN cluster to failover.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
