[
https://issues.apache.org/jira/browse/YARN-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676618#comment-16676618
]
Akira Ajisaka commented on YARN-8975:
-------------------------------------
Cancelling my +1. Would you fix the checkstyle warning?
{noformat}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/YarnServiceJobSubmitter.java:219:
Writer w = new OutputStreamWriter(new FileOutputStream(file),
StandardCharsets.UTF_8);: Line is longer than 80 characters (found 90).
[LineLength]{noformat}
> Use predefined Charset object StandardCharsets.UTF_8 instead of String "UTF-8"
> ------------------------------------------------------------------------------
>
> Key: YARN-8975
> URL: https://issues.apache.org/jira/browse/YARN-8975
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Zhankun Tang
> Assignee: Zhankun Tang
> Priority: Trivial
> Attachments: YARN-8975-trunk.001.patch
>
>
> {code:java}
> Writer w = new OutputStreamWriter(new FileOutputStream(file), "UTF-8");{code}
> Could be refactored to this to improve a little bit performance due to avoid
> string lookup:
> {code:java}
> Writer w = new OutputStreamWriter(new FileOutputStream(file),
> StandardCharsets.UTF_8);{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
