[ 
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680570#comment-16680570
 ] 

Wangda Tan commented on YARN-8763:
----------------------------------

[~sunilg] , I highly suggest reverting this from branch-3.2 if possible. Given 
this will be only utilized by interactive docker shell in the short term. 
Changes of the patch (all the way to CE) are unnecessarily risky to 3.2.0. We 
can consider backporting the docker interactive shell feature back to 3.2.x 
once we finish development and testing, etc. 

If you need to roll another RC, please get it reverted. I saw you created 
branch-3.2 on Oct 2nd, but this patch committed on Oct 5, may be it is 
committed to branch-3.2 by mistake.

If you haven't finished your RC artifacts, please get revert it. Otherwise 
please update fix version of the Jira to 3.2.0 to reflect the truth and revert 
it if another RC required.

Thanks,

> Add WebSocket logic to the Node Manager web server to establish servlet
> -----------------------------------------------------------------------
>
>                 Key: YARN-8763
>                 URL: https://issues.apache.org/jira/browse/YARN-8763
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zian Chen
>            Assignee: Zian Chen
>            Priority: Major
>              Labels: Docker
>             Fix For: 3.3.0
>
>         Attachments: YARN-8763-001.patch, YARN-8763.002.patch, 
> YARN-8763.003.patch, YARN-8763.004.patch, YARN-8763.005.patch
>
>
> The reason we want to use WebSocket servlet to serve the backend instead of 
> establishing the connection through HTTP is that WebSocket solves a few 
> issues with HTTP which needed for our scenario,
>  # In HTTP, the request is always initiated by the client and the response is 
> processed by the server — making HTTP a unidirectional protocol, while web 
> socket provides the Bi-directional protocol which means either client/server 
> can send a message to the other party.
>  # Full-duplex communication — client and server can talk to each other 
> independently at the same time
>  # Single TCP connection — After upgrading the HTTP connection in the 
> beginning, client and server communicate over that same TCP connection 
> throughout the lifecycle of WebSocket connection



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to