[
https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680848#comment-16680848
]
Sunil Govindan commented on YARN-8902:
--------------------------------------
Thanks [~cheersyang]
Few comments.
1. In VolumeImpl, we are not using AsynDispatcher. Rather we use normal
EventHander, i suppose we are not looking for heavy performance optimization,
howver pls help to check whether its needed in our context.
2. In VolumeImpl, do we need to handle state transitions for unpublish events.
Such as volume is closed/unpublished by external etc.
3. In VolumeProvisioningResults#call, we invoke ValidateVolumeEvent and
ControllerPublishVolumeEvent. It could be possible that ValidateVolumeEvent
might itself throw some error. Hence second call may not be needed.
4. In VolumeProvisioningResults#call, need to change to LOG.debug from info.
> Add volume manager that manages CSI volume lifecycle
> ----------------------------------------------------
>
> Key: YARN-8902
> URL: https://issues.apache.org/jira/browse/YARN-8902
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Attachments: YARN-8902.001.patch, YARN-8902.002.patch,
> YARN-8902.003.patch, YARN-8902.004.patch, YARN-8902.005.patch,
> YARN-8902.006.patch, YARN-8902.007.patch, YARN-8902.008.patch
>
>
> The CSI volume manager is a service running in RM process, that manages all
> CSI volumes' lifecycle. The details about volume's lifecycle states can be
> found in [CSI
> spec|https://github.com/container-storage-interface/spec/blob/master/spec.md].
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
