[
https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685247#comment-16685247
]
Sunil Govindan commented on YARN-8881:
--------------------------------------
Thanks [~tangzhankun]
Few comments
# In Device class, any reason why using Boxed type Integer. It may be better
to use int
# DevicePlugin is placed in hadoop-yarn-server-nodemanager package. Is that
correct?
# DevicePlugin: do we need validation interface api to ensure basic sanity is
done during allocation?
# Why DeviceRegisterRequest need to serializable?
# who will really invoke adapter.getNodeResourceHandlerInstance() ?
# DevicePluginAdapter cleanup is missing? Does it need to be handled by
ResourcePluginManager?
# In below case, do we need to throw exception?
if (pluginMap.containsKey(resourceName)) {
throw new YarnRuntimeException(resourceName
+ " already registered! Please change resource type name"); 162
}
> Phase 1 - Add basic pluggable device plugin framework
> -----------------------------------------------------
>
> Key: YARN-8881
> URL: https://issues.apache.org/jira/browse/YARN-8881
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Zhankun Tang
> Assignee: Zhankun Tang
> Priority: Major
> Attachments: YARN-8881-trunk.001.patch, YARN-8881-trunk.002.patch,
> YARN-8881-trunk.003.patch, YARN-8881-trunk.004.patch,
> YARN-8881-trunk.005.patch, YARN-8881-trunk.006.patch,
> YARN-8881-trunk.007.patch, YARN-8881-trunk.008.patch
>
>
> It includes adding support in "ResourcePluginManager" to load plugin classes
> based on configuration, an interface for the vendor to implement and the
> adapter to decouple plugin and YARN internals. And the vendor device resource
> discovery will be ready after this support
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
