[ https://issues.apache.org/jira/browse/YARN-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785571#comment-13785571 ]
Bikas Saha commented on YARN-1256: ---------------------------------- Can we do a null check for serviceData. And can we please create a new exception similar to InvalidContainerException. e.g. InvalidAuxServiceException. {code} + Map<String, ByteBuffer> serviceData = getAuxServiceMetaData(); + for (Map.Entry<String, ByteBuffer> meta : launchContext.getServiceData() + .entrySet()) { + if (null == serviceData.get(meta.getKey())) { + throw new YarnException("The auxService:" + meta.getKey() + + " does not exist"); + } + } {code} > NM silently ignores non-existent service in StartContainerRequest > ----------------------------------------------------------------- > > Key: YARN-1256 > URL: https://issues.apache.org/jira/browse/YARN-1256 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 2.1.1-beta > Reporter: Bikas Saha > Assignee: Xuan Gong > Priority: Critical > Fix For: 2.1.2-beta > > Attachments: YARN-1256.1.patch, YARN-1256.2.patch > > > A container can set token service metadata for a service, say > shuffle_service. If that service does not exist then the errors is silently > ignored. Later, when the next container wants to access data written to > shuffle_service by the first task, then it fails because the service does not > have the token that was supposed to be set by the first task. -- This message was sent by Atlassian JIRA (v6.1#6144)