[
https://issues.apache.org/jira/browse/YARN-9001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686076#comment-16686076
]
Zac Zhou commented on YARN-9001:
--------------------------------
Thanks, [~leftnoteasy]
I checked the code and found there were no differences between branch-3.3 and
branch-3.2. So all changes should have been pushed to branch-3.2.
I found that there is an issue in the patch, which would cause merge failed in
branch 3.2.
The git diff was:
{code:java}
+ String appStatus=serviceClient.getStatusString(jobName);
+ Service serviceSpec= ServiceApiUtil.jsonSerDeser.fromJson(appStatus);
+ JobStatus jobStatus = JobStatusBuilder.fromServiceSpec(serviceSpec);
+ return jobStatus;
+ }
- Service serviceSpec = this.serviceClient.getStatus(jobName);
- return JobStatusBuilder.fromServiceSpec(serviceSpec);{code}
and it should be:
{code:java}
- Service serviceSpec = this.serviceClient.getStatus(jobName);
+ String appStatus=serviceClient.getStatusString(jobName);
+ Service serviceSpec= ServiceApiUtil.jsonSerDeser.fromJson(appStatus);
JobStatus jobStatus = JobStatusBuilder.fromServiceSpec(serviceSpec);
return jobStatus;{code}
I checked the code in the trunk. The patch was merged correctly to the trunk.
So I generated a patch for branch-3.2, named YARN-9001-branch-3.2.001.patch,
and tested it. it should work for branch 3.2.
I'm not sure why Jenkins didn't fail when patches were attached. ~
In the future, I'll check if patches can be applied to trunk and branch 3.2.
Thanks
> [Submarine] Use AppAdminClient instead of ServiceClient to sumbit jobs
> ----------------------------------------------------------------------
>
> Key: YARN-9001
> URL: https://issues.apache.org/jira/browse/YARN-9001
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Zac Zhou
> Assignee: Zac Zhou
> Priority: Major
> Fix For: 3.3.0
>
> Attachments: YARN-9001-branch-3.2.001.patch, YARN-9001.001.patch,
> YARN-9001.002.patch, YARN-9001.003.patch, YARN-9001.004.patch,
> YARN-9001.005.patch
>
>
> For now, submarine submit a service to yarn by using ServiceClient, We should
> change it to AppAdminClient
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
