[ 
https://issues.apache.org/jira/browse/YARN-9020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

tianjuan updated YARN-9020:
---------------------------
    Description: 
bug at setAbsoluteCapacity

private void deriveCapacityFromAbsoluteConfigurations(String label,
 Resource clusterResource, ResourceCalculator rc, CSQueue childQueue) {

// 3. Update absolute capacity as a float based on parent's minResource and
 // cluster resource.
 childQueue.getQueueCapacities().setAbsoluteCapacity(label,
 (float) childQueue.getQueueCapacities().getCapacity()
 / getQueueCapacities().getAbsoluteCapacity(label));

 

should be childQueue.getQueueCapacities().setAbsoluteCapacity(label,
(float) childQueue.getQueueCapacities().{color:#f6c342}getCapacity(label){color}
/ getQueueCapacities().getAbsoluteCapacity(label));

  was:
bug at setAbsoluteCapacity

private void deriveCapacityFromAbsoluteConfigurations(String label,
 Resource clusterResource, ResourceCalculator rc, CSQueue childQueue) {

 /*
 * In case when queues are configured with absolute resources, it is better
 * to update capacity/max-capacity etc w.r.t absolute resource as well. In
 * case of computation, these values wont be used any more. However for
 * metrics and UI, its better these values are pre-computed here itself.
 */

 // 1. Update capacity as a float based on parent's minResource
 childQueue.getQueueCapacities().setCapacity(label,
 rc.divide(clusterResource,
 childQueue.getQueueResourceQuotas().getEffectiveMinResource(label),
 getQueueResourceQuotas().getEffectiveMinResource(label)));

 // 2. Update max-capacity as a float based on parent's maxResource
 childQueue.getQueueCapacities().setMaximumCapacity(label,
 rc.divide(clusterResource,
 childQueue.getQueueResourceQuotas().getEffectiveMaxResource(label),
 getQueueResourceQuotas().getEffectiveMaxResource(label)));

 // 3. Update absolute capacity as a float based on parent's minResource and
 // cluster resource.
 childQueue.getQueueCapacities().setAbsoluteCapacity(label,
 (float) childQueue.getQueueCapacities().getCapacity()
 / getQueueCapacities().getAbsoluteCapacity(label));


> bug when setAbsoluteCapacity(String label, float value)
> -------------------------------------------------------
>
>                 Key: YARN-9020
>                 URL: https://issues.apache.org/jira/browse/YARN-9020
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: tianjuan
>            Priority: Major
>
> bug at setAbsoluteCapacity
> private void deriveCapacityFromAbsoluteConfigurations(String label,
>  Resource clusterResource, ResourceCalculator rc, CSQueue childQueue) {
> // 3. Update absolute capacity as a float based on parent's minResource and
>  // cluster resource.
>  childQueue.getQueueCapacities().setAbsoluteCapacity(label,
>  (float) childQueue.getQueueCapacities().getCapacity()
>  / getQueueCapacities().getAbsoluteCapacity(label));
>  
> should be childQueue.getQueueCapacities().setAbsoluteCapacity(label,
> (float) 
> childQueue.getQueueCapacities().{color:#f6c342}getCapacity(label){color}
> / getQueueCapacities().getAbsoluteCapacity(label));



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to