[ https://issues.apache.org/jira/browse/YARN-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686554#comment-16686554 ]
Rohith Sharma K S commented on YARN-8303: ----------------------------------------- Some comments YarnClientImpl # Most of the API's does't have *return* after ahs2client.XXXX() is called. This causes always ATS1.5 API to call! {code:java} if (timelineV2ServiceEnabled) { try { ahsV2Client.getApplicationAttemptReport(appAttemptId); } catch (Exception ex) { LOG.warn("Failed to fetch application attempt report from " + "ATS v2", ex); } } {code} # Newly added method getContainerReportFromHistory has ambiguity. After catching, again ahsV2Client is called!. {code:java} private List<ContainerReport> getContainerReportFromHistory( ApplicationAttemptId applicationAttemptId) throws IOException, YarnException { List<ContainerReport> containersListFromAHS = null; if (timelineV2ServiceEnabled) { try { containersListFromAHS = ahsV2Client.getContainers(applicationAttemptId); } catch (Exception e) { LOG.warn("Got an error while fetching container report from ATSv2", e); if (historyServiceEnabled) { containersListFromAHS = ahsV2Client.getContainers( applicationAttemptId); } else { throw e; } } } else if (historyServiceEnabled) { containersListFromAHS = historyClient.getContainers(applicationAttemptId); } return containersListFromAHS; } {code} > YarnClient should contact TimelineReader for application/attempt/container > report > --------------------------------------------------------------------------------- > > Key: YARN-8303 > URL: https://issues.apache.org/jira/browse/YARN-8303 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Rohith Sharma K S > Assignee: Abhishek Modi > Priority: Critical > Attachments: YARN-8303.001.patch, YARN-8303.002.patch, > YARN-8303.003.patch, YARN-8303.poc.patch > > > YarnClient get app/attempt/container information from RM. If RM doesn't have > then queried to ahsClient. When ATSv2 is only enabled, yarnClient will result > empty. > YarnClient is used by many users which result in empty information for > app/attempt/container report. > Proposal is to have adapter from yarn client so that app/attempt/container > reports can be generated from AHSv2Client which does REST API to > TimelineReader and get the entity and convert it into app/attempt/container > report. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org