[
https://issues.apache.org/jira/browse/YARN-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687604#comment-16687604
]
Weiwei Yang commented on YARN-8953:
-----------------------------------
Hi [~sunilg]
Thanks for the comments.
#1 fixed
#2 fixed
#3 GetPluginInfoRequest is a abstract class
#4 Yes, we can start with supporting 1 capability for now but API level we
should be compatible with CSI, I just fixed this.
#5 fixed
#6 Valid concenr, I have same feeling, let me fix this.
#7 No, YarnCsiAdaptor.proto will be compiled against protobuf-2.5.0, this
defines the protocol used by RM and CSI-adaptor. The only thing will be
compiled with protobuf3 is the hadoop-yarn-csi module, because it ships 3rd
party CSI proto.
#8 Are you saying we could just use proto messages defined by
yarn_csi_adaptor.proto in abstract class
\{{ValidateVolumeCapabilitiesRequest}}? I thought this class should be
self-contained, I am not sure...
#9 You are correct. hadoop-yarn-common/hadoop-yarn-api doesn't depend on
hadoop-yarn-csi
#10 \{{adaptorServiceAddress}} is expected to be a remote address, this is the
address for the adaptor and RM will need to talk with it. It can be deployed on
any NM. We will have another config for unix domain socket, that is a config
per csi-driver and that will be a local UDS file path. We will need to sort out
these configs too..
#11 {{CsiAdaptorProtocolService}} will be started along with NM, if it is
failing, NM also failed to start. No other handling is needed as far as I can
think of right now.
#12 When there is new message added, we need to add a transformer class. This
class handles the message transformation from YARN proto to CSI proto. for
preprovisioned volumes, we probably need to add 2 or 3 more transformers to get
complete lifecycle managed. The reason it is in hadoop-yarn-csi moduel was
because it needs to talk with CSI proto. In future, if we stablize YARN volume
API, then only need to update the transformer code if CSI proto updates; if
YARN volume API updates, when we only need to update PBImpl classes in
hadoop-yarn-api and corresponding transformer class.
> Add CSI driver adaptor module
> -----------------------------
>
> Key: YARN-8953
> URL: https://issues.apache.org/jira/browse/YARN-8953
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Attachments: YARN-8953.001.patch, YARN-8953.002.patch,
> YARN-8953.003.patch, YARN-8953.004.patch, csi_adaptor_workflow.png
>
>
> CSI adaptor is a layer between YARN and CSI driver, it transforms YARN
> internal concepts and boxes them according to CSI protocol. Then forward the
> call to a CSI driver. The adaptor should support both
> controller/node/identity services.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
