[
https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687713#comment-16687713
]
Zhankun Tang edited comment on YARN-8881 at 11/15/18 9:45 AM:
--------------------------------------------------------------
[~sunilg] ,
{quote}I am like +0 for this change. {{Integer.compare(id, other.getId())}}. It
could a simple {{if (id != other.getId())}}
{quote}
One question about this. The _Integer.compare(id, other.getId)_'s
implementation is below:
{code:java}
public static int compare(int x, int y) {
return (x < y) ? -1 : ((x == y) ? 0 : 1);
}{code}
Do you mean we just move it out is more performant? I didn't get your idea
clearly.
was (Author: tangzhankun):
[~sunilg] ,
{quote}I am like +0 for this change. {{Integer.compare(id, other.getId())}}. It
could a simple {{if (id != other.getId())}}
{quote}
One question about this. The _Integer.compare(id, other.getId)'_s
implementation is below:
{code:java}
public static int compare(int x, int y) {
return (x < y) ? -1 : ((x == y) ? 0 : 1);
}{code}
Do you mean we just move it out is more performant? I didn't get your idea
clearly.
> Phase 1 - Add basic pluggable device plugin framework
> -----------------------------------------------------
>
> Key: YARN-8881
> URL: https://issues.apache.org/jira/browse/YARN-8881
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Zhankun Tang
> Assignee: Zhankun Tang
> Priority: Major
> Attachments: YARN-8881-trunk.001.patch, YARN-8881-trunk.002.patch,
> YARN-8881-trunk.003.patch, YARN-8881-trunk.004.patch,
> YARN-8881-trunk.005.patch, YARN-8881-trunk.006.patch,
> YARN-8881-trunk.007.patch, YARN-8881-trunk.008.patch,
> YARN-8881-trunk.009.patch, YARN-8881-trunk.010.patch
>
>
> It includes adding support in "ResourcePluginManager" to load plugin classes
> based on configuration, an interface for the vendor to implement and the
> adapter to decouple plugin and YARN internals. And the vendor device resource
> discovery will be ready after this support
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
