[
https://issues.apache.org/jira/browse/YARN-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689000#comment-16689000
]
Weiwei Yang edited comment on YARN-9004 at 11/16/18 4:01 AM:
-------------------------------------------------------------
Hi [~jiwq]
Sorry for the late response. Thanks for fixing this, the patch looks good.
The concern I have is mostly about the maintenance effort. We have 4 branches
on 2.x versions, and 4 branches on 3.x versions, it is not a trivial effort to
get this in all these streams. If we only fix this on 3.x, then it would cause
conflicts when we want to cherry-pick patches to 2.x. So I suggest to live with
it unless there is some other benefits by fixing these. Does that make sense to
you [~jiwq]?
was (Author: cheersyang):
Hi [~jiwq]
Sorry for the late response. Thanks for fixing this, the patch looks good.
The concern I have is mostly about the maintenance effort. We have 4 branches
on 2.x versions, and 4 branches on 3.x versions, it is not a trivial effort to
get this in all these streams. If we only fix this on 3.x, then it would cause
conflicts when we want to cherry-pick patches to 2.x.
> Remove unnecessary modifier for interface belong to scheduler
> -------------------------------------------------------------
>
> Key: YARN-9004
> URL: https://issues.apache.org/jira/browse/YARN-9004
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
> Affects Versions: 2.9.1, 3.1.1, 3.0.3
> Reporter: Wanqiang Ji
> Assignee: Wanqiang Ji
> Priority: Major
> Attachments: YARN-9004.001.patch
>
>
> Modifier is redundant for interface.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
