[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691032#comment-16691032
]
Eric Yang commented on YARN-8986:
---------------------------------
[~Charo Zhang] Thank you for the patch. You are right that set_network command
checks if the network name is allowed. As long as add_ports_mapping_to_command
is after set_network, then there is no need to check network name again. I
think the earlier patch was before set_network, this was the reason that I ask
for validation. If would be good to use YARN-8986.001.patch to keep different
version of the patch without removing the older version. This would be easier
to track the conversation and progress of the on-going improvement. Since
add_ports_mapping_to_command is after set_network, then there is no need to do
network name validation again after docker network inspect command. Please add
a test case to test_docker_util.cc to make sure that the valid and invalid
input are both verified.
> publish all exposed ports to random ports when using bridge network
> -------------------------------------------------------------------
>
> Key: YARN-8986
> URL: https://issues.apache.org/jira/browse/YARN-8986
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Affects Versions: 3.1.1
> Reporter: Charo Zhang
> Assignee: Charo Zhang
> Priority: Minor
> Labels: Docker
> Attachments: YARN-8986.patch
>
>
> it's better to publish all exposed ports to random ports（-P） or support port
> mapping（-p） for bridge network when using bridge network for docker container.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
