[
https://issues.apache.org/jira/browse/YARN-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692687#comment-16692687
]
Bibin A Chundatt commented on YARN-8934:
----------------------------------------
Thank you [~BilwaST] for patch
Few comments
# RMWebAppUtil.setupSecurityAndFilters(conf, null); uses RM's http filter
property. We need new property
# Similar to SCM its better to have overview
{code:java}
route("/", SCMController.class, "overview");
{code}
# hadoop.yarn.conf.TestYarnConfigurationFields is related to patch. Add
property in testclass
# Revert following change
{code:java}
63 hadoop-ozone/docs/public
64 /.metadata/
{code}
# Conf variable is not required use {{globalPolicyGenerator.setConfig(conf);}}
in startGPG and use getConf()
# For webApp instance can we use
{{WebApps.$for("gpg").at(bindAddress).start(gpgWebApp);}} similar to scm.
# Fix unused imports , checkstyle issues too.
> [GPG] Add JvmMetricsInfo and pause monitor
> ------------------------------------------
>
> Key: YARN-8934
> URL: https://issues.apache.org/jira/browse/YARN-8934
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bilwa S T
> Assignee: Bilwa S T
> Priority: Major
> Attachments: YARN-8934-001.patch, YARN-8934-YARN-7402.v1.patch,
> image-2018-11-19-15-37-18-647.png
>
>
> Similar to resourcemanager and nodemanager serivce we can add JvmMetricsInfo
> to gpg service.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
