[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693797#comment-16693797
]
Charo Zhang edited comment on YARN-8986 at 11/20/18 9:29 PM:
-------------------------------------------------------------
[~eyang] I think network_name is allowed to not exist, and i find set_network
return 0 when do not get "net" key. so i process it with the same way in
add_ports_mapping_to_command, if network_name is null, it return 0 to do
nothing, there is no need to set default network is bridge. At same time, i add
two more test cases in test_docker_util.cc if network_name not exist.
The latest 005 patch is uploaded.
was (Author: charo zhang):
[~eyang] I think network_name is allowed to not exist, and i find set_network
return 0 when do not get "net" key. so i process it with the same way in
add_ports_mapping_to_command, if network_name is null, it return 0 to do
nothing, there is not need to set default network is bridge. At same time, i
add two more test cases in test_docker_util.cc if network_name not exist.
The latest 005 patch is uploaded.
> publish all exposed ports to random ports when using bridge network
> -------------------------------------------------------------------
>
> Key: YARN-8986
> URL: https://issues.apache.org/jira/browse/YARN-8986
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Affects Versions: 3.1.1
> Reporter: Charo Zhang
> Assignee: Charo Zhang
> Priority: Minor
> Labels: Docker
> Attachments: YARN-8986.001.patch, YARN-8986.002.patch,
> YARN-8986.003.patch, YARN-8986.004.patch, YARN-8986.005.patch
>
>
> it's better to publish all exposed ports to random ports（-P） or support port
> mapping（-p） for bridge network when using bridge network for docker container.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
