[
https://issues.apache.org/jira/browse/YARN-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697323#comment-16697323
]
Szilard Nemeth commented on YARN-9047:
--------------------------------------
Thanks [~wilfreds] for the review!
1. Removed the import (don't know how that ended up in the code at all)
2. Started to use TestResourceUtils as you suggested.
3. Hamcrest dependency is removed, using
org.mockito.internal.matchers.InstanceOf instead hence this prints a nice
failure message if the instance is not the expected.
For your last point: I agree it's in a wrong place. I'll file a jira for this
soon.
> FairScheduler: default resource calculator is not resource type aware
> ---------------------------------------------------------------------
>
> Key: YARN-9047
> URL: https://issues.apache.org/jira/browse/YARN-9047
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Reporter: Wilfred Spiegelenburg
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9047.001.patch
>
>
> The FairScheduler#getResourceCalculator always returns the default resource
> calculator. The default calculator is not resource type aware and should only
> be used if there are no resource types configured.
> We need to make sure that in we the direct hard code reference to
> {{RESOURCE_CALCULATOR}} is either safe to use in all cases or is not used in
> the scheduler.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
