[ 
https://issues.apache.org/jira/browse/YARN-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700031#comment-16700031
 ] 

Weiwei Yang commented on YARN-9037:
-----------------------------------

Hi [~sunilg]

The patch overall looks good. Something I am not quite sure about

ResourceUtils has some other public methods, e.g getResourceTypesArray(), this 
is used in DomainResourceFairnessPolicy to compute shares, would that cause 
issue when the array has some non-countable resource?

Apart from that, can we add some UT for verification? E.g to create some 
resource requests with such tag, verify the get methods as well as the 
allocation result.

Thanks

> [CSI] Ignore volume resource in resource calculators based on tags
> ------------------------------------------------------------------
>
>                 Key: YARN-9037
>                 URL: https://issues.apache.org/jira/browse/YARN-9037
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Sunil Govindan
>            Priority: Major
>         Attachments: YARN-9037-002.patch, YARN-9037.001.patch
>
>
> The pre-provisioned volume is specified as a resource, but such resource is 
> different comparing to what is managed now in YARN, e.g memory, vcores. They 
> are constrained by 3rd party storage systems, so it looks more like an 
> unmanaged resource. In such case, we need to ignore the resource calculation 
> over them in the resource calculators. This can be done based on the resource 
> tags.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to