[
https://issues.apache.org/jira/browse/YARN-9044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698514#comment-16698514
]
Suma Shivaprasad edited comment on YARN-9044 at 11/27/18 11:06 AM:
-------------------------------------------------------------------
[~rohithsharma] +1. One minor comment - Please move this section to a private
method to remove duplication
{noformat}
if (YarnConfiguration.timelineServiceV1Enabled(conf)) {
690 amContainersList =
691 getAMContainerInfoForAHSWebService(conf, appId);
692 getAMContainerLists =
693
createContainerLogsRequestForMasterContainer(requests,
694 request, amContainersList, "amContainerId");
695 }
{noformat}
was (Author: suma.shivaprasad):
[~rohithsharma] +1. One minor comment - Please move this section to a private
method to remove duplication
{ noformat}
if (YarnConfiguration.timelineServiceV1Enabled(conf)) {
690 amContainersList =
691 getAMContainerInfoForAHSWebService(conf, appId);
692 getAMContainerLists =
693
createContainerLogsRequestForMasterContainer(requests,
694 request, amContainersList, "amContainerId");
695 }
{ noformat}
> LogsCLI should contact ATSv2 for "-am" option
> ---------------------------------------------
>
> Key: YARN-9044
> URL: https://issues.apache.org/jira/browse/YARN-9044
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Priority: Major
> Attachments: YARN-9044.01.patch, YARN-9044.01.patch,
> YARN-9044.02.patch
>
>
> *yarn logs -applicationId appId -am 1* contact ATS1.5 even though it is not
> configured. Rather LogsCLI should contact ATSv2 for AM container info.
> Alternative to above one can use *yarn logs -containerId <am-contanier-id>*
> to fetch logs. But -am option should also work along with ATSv2.0
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
