[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700424#comment-16700424
]
Wanqiang Ji commented on YARN-9041:
-----------------------------------
Hi [~Steven Rand], thanks for your detailed review.
{quote}I'm curious, what's the motivation for reordering the conditions in the
{{if}} block?
{quote}
If we not allowed relax locality, it will executes three statements before used
this patch. Otherwise it executes only one statement after used this patch. So
I think reorder the conditions can improve the performance.
I hope my explanation can give u some help.
> Optimize FSPreemptionThread#identifyContainersToPreempt method
> --------------------------------------------------------------
>
> Key: YARN-9041
> URL: https://issues.apache.org/jira/browse/YARN-9041
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler preemption
> Reporter: Wanqiang Ji
> Assignee: Wanqiang Ji
> Priority: Major
> Attachments: YARN-9041.001.patch, YARN-9041.002.patch
>
>
> In FSPreemptionThread#identifyContainersToPreempt method, I suggest if AM
> preemption, and locality relaxation is allowed, then the search space is
> expanded to all nodes changed to the remaining nodes. The remaining nodes are
> equal to all nodes minus the potential nodes.
> Judging condition changed to:
> # rr.getRelaxLocality()
> # !ResourceRequest.isAnyLocation(rr.getResourceName())
> # bestContainers != null
> # bestContainers.numAMContainers > 0
> If I understand the deviation, please criticize me. thx~
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
