[
https://issues.apache.org/jira/browse/YARN-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708140#comment-16708140
]
Wanqiang Ji commented on YARN-9041:
-----------------------------------
I'm so sorry for this brought unnecessary trouble to you, [~yufeigu].
{quote}1. \{{ * @return list preemptable containers}} should be something like
{{the list of best preemptable containers for the resource request}}
{quote}
In v7 patch, I had modified the return javadoc comment by your suggestion.
{quote}We still need some comments in both tests to clarify which logic path
the test are for. For example, we can add comments in
{{testRelaxLocalityToPreemptLessAM}} to say that it tests the case that there
is no less-AM-container solution in the remaining nodes.
{quote}
In v7 patch, I renamed the two tests with clarify name and also added comments
for it.
Thanks for your help very much.
> Optimize FSPreemptionThread#identifyContainersToPreempt method
> --------------------------------------------------------------
>
> Key: YARN-9041
> URL: https://issues.apache.org/jira/browse/YARN-9041
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler preemption
> Reporter: Wanqiang Ji
> Assignee: Wanqiang Ji
> Priority: Major
> Attachments: YARN-9041.001.patch, YARN-9041.002.patch,
> YARN-9041.003.patch, YARN-9041.004.patch, YARN-9041.005.patch,
> YARN-9041.006.patch, YARN-9041.007.patch
>
>
> In FSPreemptionThread#identifyContainersToPreempt method, I suggest if AM
> preemption, and locality relaxation is allowed, then the search space is
> expanded to all nodes changed to the remaining nodes. The remaining nodes are
> equal to all nodes minus the potential nodes.
> Judging condition changed to:
> # rr.getRelaxLocality()
> # !ResourceRequest.isAnyLocation(rr.getResourceName())
> # bestContainers != null
> # bestContainers.numAMContainers > 0
> If I understand the deviation, please criticize me. thx~
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
