[
https://issues.apache.org/jira/browse/YARN-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrey Klochkov updated YARN-465:
---------------------------------
Attachment: YARN-465-trunk--n4.patch
Ravi, this is not my patch so please keep in mind I'm digging into this code as
you are. Alexey wouldn't be available to make fixes so I'm taking this on me so
the contribution wouldn't be lost.
1-2. As I see, WebAppProxy.start() method is used in another test, so that
should be the reason it's not a part of the "main" method. The "join" method is
removed as it's not used anymore.
3. I think that it is meant to log "port", not "originalPort". The "port"
variable is set in WebAppProxyForTest.start() to the actual port which the
server binds to.
4. Indeed core-default.xml is not needed. I'm replacing it with making this
configuration in the code of the test itself.
5. It must be setName("proxy") as this is the name of the webapp under
hadoop-yarn-common/src/main/resources/webapps. If you set it to anything else
that would lead to ClassNotFoundException. I made the message about the port
number more detailed.
6. I added the check which verifies that the cookie is present in one case and
is absent in another.
7. Yes, I don't see why testWebAppProxyServer is needed in the presense of
testWebAppProxyServlet. Removing.
8. The test testWebAppProxyServerMainMethod is testing that the server is
starting successfully. The counter is used to wait for the server to start.
Attaching the updated patch for trunk
> fix coverage org.apache.hadoop.yarn.server.webproxy
> ----------------------------------------------------
>
> Key: YARN-465
> URL: https://issues.apache.org/jira/browse/YARN-465
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 3.0.0, 0.23.7, 2.0.4-alpha
> Reporter: Aleksey Gorshkov
> Assignee: Andrey Klochkov
> Attachments: YARN-465-branch-0.23-a.patch,
> YARN-465-branch-0.23.patch, YARN-465-branch-2-a.patch,
> YARN-465-branch-2--n3.patch, YARN-465-branch-2.patch, YARN-465-trunk-a.patch,
> YARN-465-trunk--n3.patch, YARN-465-trunk--n4.patch, YARN-465-trunk.patch
>
>
> fix coverage org.apache.hadoop.yarn.server.webproxy
> patch YARN-465-trunk.patch for trunk
> patch YARN-465-branch-2.patch for branch-2
> patch YARN-465-branch-0.23.patch for branch-0.23
> There is issue in branch-0.23 . Patch does not creating .keep file.
> For fix it need to run commands:
> mkdir
> yhadoop-common/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/proxy
> touch
> yhadoop-common/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/proxy/.keep
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
