[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709640#comment-16709640
]
Akhil PB edited comment on YARN-8914 at 12/5/18 6:16 AM:
---------------------------------------------------------
[~eyang] Please find the v9 patch [^YARN-8914.009.patch] with latest UI2
changes. The issues were in how requestedUser were accessed.
The code snippet {{this.get('requestedUser')}} should be
{{self.get('requestedUser')}}.
The following changes were made related to UI2 in v9 patch.
# Removed DOM access and termLink code from {{models/yarn-container.js and
serializers/yarn-container.js}}, since these were not used. Since we only need
nodeHttpAddress, containerId and user for termLink.
# Removed Terminal column from attempts table in
{{components/timeline-view.js}}.
# Fixed requestedUser issues in {{components/timeline-view.js and
templates/components/container-table.hbs}}.
Please verify that all your changes are there in v9 patch.
was (Author: akhilpb):
[~eyang] Please find the v9 patch [^YARN-8914.009.patch] with latest UI2
changes. The issues were in how requestedUser were accessed.
The code snippet {{this.get('requestedUser')}} should be
{{self.get('requestedUser')}}.
The following changes were made related to UI2 in v9 patch.
# Removed DOM access and termLink code from {{models/yarn-container.js and
serializers/yarn-container.js}}, since these were not used.
# Removed Terminal column from attempts table in
{{components/timeline-view.js}}.
# Fixed requestedUser issues in {{components/timeline-view.js and
templates/components/container-table.hbs}}.
Please verify that all your changes are there in v9 patch.
> Add xtermjs to YARN UI2
> -----------------------
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch, YARN-8914.008.patch,
> YARN-8914.009.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
