[
https://issues.apache.org/jira/browse/YARN-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710646#comment-16710646
]
Wangda Tan commented on YARN-8822:
----------------------------------
[~Charo Zhang],
Thanks for the patch, apologize missed this Jira.
I took a quick look, in general patch looks good. My only concern is, should we
add addition check to the runtime used by container-executor binary. You can
use the method add_param_to_command_if_allowed to check if a runtime is
allowed. The reason is c-e runs as root, we saw some security related issues
before. By default allowed runtime should be empty.
And it you could share 1) documentation about new configs (add doc to YARN
doc). 2) test report. We can be more confident to get this patch committed.
[~tangzhankun], Regarding use the new device plugin framework vs. use old
framework, personally I think we can do that slowly. Given device plugin is not
ready yet, we can migrate plugins to device plugin framework once it is ready.
Regarding to target version, we should always get patch committed to trunk
first, and backport to older release lines. [~Charo Zhang], let's try to get
trunk patch done and backport to branch-3.1, branch-3.2. I expect we have about
1 week time before 3.1.2 release, it's best if we can finish the patch before
3.1.2 release.
> Nvidia-docker v2 support
> ------------------------
>
> Key: YARN-8822
> URL: https://issues.apache.org/jira/browse/YARN-8822
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 3.1.1
> Reporter: Zhankun Tang
> Assignee: Charo Zhang
> Priority: Major
> Labels: Docker
> Attachments: YARN-8822-branch-3.1.1.001.patch, YARN-8822.001.patch,
> YARN-8822.002.patch
>
>
> To run a GPU container with Docker, we have nvdia-docker v1 support already
> but is deprecated per
> [here|https://github.com/NVIDIA/nvidia-docker/wiki/About-version-2.0]. We
> should support nvdia-docker v2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
