[
https://issues.apache.org/jira/browse/YARN-9051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710796#comment-16710796
]
Haibo Chen commented on YARN-9051:
----------------------------------
Thanks [~snemeth] for the patch. Looks good overall. Some nits:
1) TestTaskAttempt and TestSchedulerUtils.java have some shuffling of import
statements that is unrelated to this change. Let's revert those changes. (If
your IDE does so, make sure turn them off)
2) CustomResourceTypeCOnfigurationProvider.DEFAULT_UNIT is misleading because
'k' is not always used as the unit when no unit is provided, e.g. public
static void initResourceTypes(String... resourceTypes) {}, unit is left as
empty.
3) Given that CustomResourceTypesConfigurationProvider now calls ResourceUtils
to set or reset resource types globally, it is no longer just an implementation
of LocalConfigurationProvider. I think we can rename it to
CustomResourceTypeConfigurationUtils.
> Integrate multiple CustomResourceTypesConfigurationProvider implementations
> into one
> ------------------------------------------------------------------------------------
>
> Key: YARN-9051
> URL: https://issues.apache.org/jira/browse/YARN-9051
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-9051.001.patch
>
>
> CustomResourceTypesConfigurationProvider (extends LocalConfigurationProvider)
> has 5 implementations on trunk nowadays.
> These could be integrated into 1 common class.
> Also,
> {{org.apache.hadoop.yarn.util.resource.TestResourceUtils#addNewTypesToResources}}
> has similar functionality so this can be considered as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
