[
https://issues.apache.org/jira/browse/YARN-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712108#comment-16712108
]
Haibo Chen commented on YARN-9087:
----------------------------------
Thanks [~snemeth] for the patch. A few nits about the patch.
1) Not sure why the logging in ContainerScheduler is removed. I think we should
keep it. Container Scheduler would try to bootstrap cgroups if cgroups has not
been initialized elsewhere.
2) All the toString() methods include the class name. We can used
XXX.class.getName() instead in case the name changes.
3) IMO, only immutable fields that are initialized in the constructor should be
included in the toString(). It may be confusing/misleading if the value changes
later after toString() is called.
> Better logging for initialization of Resource plugins
> -----------------------------------------------------
>
> Key: YARN-9087
> URL: https://issues.apache.org/jira/browse/YARN-9087
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9087.001.patch
>
>
> The patch includes the following enahncements for logging:
> - Logging initializer code of resource handlers in
> {{LinuxContainerExecutor#init}}
> - Logging initializer code of resource plugins in
> {{ResourcePluginManager#initialize}}
> - Added toString to {{ResourceHandlerChain}}
> - Added toString to all implementations to subclasses of {{ResourcePlugin}}
> as they are printed in {{ResourcePluginManager#initialize}}
> - Added toString to all implementations to subclasses of {{ResourceHandler}}
> as they are printed as a field of the {{LinuxContainerExecutor#init}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
