[ 
https://issues.apache.org/jira/browse/YARN-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714309#comment-16714309
 ] 

Akhil PB edited comment on YARN-9089 at 12/10/18 5:37 AM:
----------------------------------------------------------

[~eyang] We should not call ajax call in models. The calls should be made in 
either in the adapter or in this case loader.js. Models are like POJOs, jus to 
hold the data structure and related properties.
In this case, we need the NM port. Could you please try to get the port and add 
it to env object in initializers/loader.js. After that, you can access env 
object in yarn-component-instance controller file to access the port. Form the 
termLink url in the controller using the port and model data.
{quote}{{ {{outlet userInfo=model.userInfo}} }}
{quote}
Do we need this code? Since you are adding userInfo to 
yarn-component-instance/info route, it should be available in info.hbs page in 
model object. I am not sure passing params to outlet works or not in ember.

Thanks.


was (Author: akhilpb):
[~eyang] We should not call ajax call in models. The calls should be made in 
either in the adapter or in this case loader.js. Models are like POJOs, jus to 
hold the data structure and related properties.
In this case, we need the NM port. Could you please try to get the port and add 
it to env object in initializers/loader.js. After that, you can access env 
object in yarn-component-instance controller file to access the port. Form the 
termLink url in the controller using the port and model data.
{quote}{{ {{outlet userInfo=model.userInfo}} }}
{quote}
Do we need this code? Since you are adding userInfo to 
yarn-component-instance/info route, it should be available in info.hbs page in 
model object.

Thanks.

> Add Terminal Link to Service component instance page for UI2
> ------------------------------------------------------------
>
>                 Key: YARN-9089
>                 URL: https://issues.apache.org/jira/browse/YARN-9089
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn-ui-v2
>    Affects Versions: 3.3.0
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Major
>         Attachments: YARN-9089.001.patch
>
>
> In UI2, Service > Component > Component Instance uses Timeline server to 
> aggregate information about Service component instance.  Timeline server does 
> not have the full information like the port number of the node manager, or 
> the web protocol used by the node manager.  It requires some changes to 
> aggregate node manager information into Timeline server in order to compute 
> the Terminal link.  For reducing the scope of YARN-8914, it is better file 
> this as a separate task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to