[
https://issues.apache.org/jira/browse/YARN-9095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718699#comment-16718699
]
ASF GitHub Bot commented on YARN-9095:
--------------------------------------
Github user szilard-nemeth commented on the issue:
https://github.com/apache/hadoop/pull/445
Hi @vbmudalige !
Thanks for this patch.
LGTM + 1 (non-binding)
> Removed Unused field from Resource: NUM_MANDATORY_RESOURCES
> -----------------------------------------------------------
>
> Key: YARN-9095
> URL: https://issues.apache.org/jira/browse/YARN-9095
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Vidura Bhathiya Mudalige
> Priority: Trivial
> Labels: newbie, newbie++
>
> I suppose this constant remained in the code from historical reasons, but
> this is not used anymore so it could be removed.
> This field is especially confusing for new readers, as ResourceInformation
> now has a field named MANDATORY_RESOURCES and this map contains not only
> memory and vcores but GPU and FPGA as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
