[
https://issues.apache.org/jira/browse/YARN-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719664#comment-16719664
]
Billie Rinaldi commented on YARN-9075:
--------------------------------------
Thanks for the review, [~leftnoteasy]!
{quote}First I suggest to make all methods which will change internal data
structure to synchronized method. Unless you feel there will be some
performance issues, I would prefer to make it simpler.
{quote}
This makes sense to me. I had loadManifest as synchronized in patch 1, and it
gave findbugs errors about inconsistent synchronization. But perhaps there is a
different way to address the findbugs problem.
[https://builds.apache.org/job/PreCommit-YARN-Build/22791/artifact/out/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html]
{quote}Why change ShuffleHandler?
{quote}
Because ShuffleHandler does not unregister its metrics source on stop, when the
NM reloads ShuffleHandler an error occurs saying the metrics source already
exists.
Here are the example manifests I have been testing with. If anyone has
suggestions for other aux services I could test, I'd be happy to try more.
{code}
{
"services": [
{
"name": "mapreduce_shuffle",
"configuration": {
"properties": {
"class.name": "org.apache.hadoop.mapred.ShuffleHandler"
}
}
}
]
}
{code}
{code}
{
"services": [
{
"name": "mapreduce_shuffle",
"version": "2",
"configuration": {
"properties": {
"class.name": "org.apache.hadoop.mapred.ShuffleHandler",
"mapreduce.shuffle.transfer.buffer.size": "102400",
"mapreduce.shuffle.port": "13563"
}
}
}
]
}
{code}
> Dynamically add or remove auxiliary services
> --------------------------------------------
>
> Key: YARN-9075
> URL: https://issues.apache.org/jira/browse/YARN-9075
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Priority: Major
> Attachments: YARN-9075.001.patch, YARN-9075.002.patch,
> YARN-9075.003.patch, YARN-9075_Dynamic_Aux_Services_V1.pdf
>
>
> It would be useful to support adding, removing, or updating auxiliary
> services without requiring a restart of NMs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
