[ 
https://issues.apache.org/jira/browse/YARN-9038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723709#comment-16723709
 ] 

Weiwei Yang commented on YARN-9038:
-----------------------------------

Hi [~sunilg]

I agree with most of your comments, and will upload a new patch to address 
them. The only exception is
{quote}In proto, if NodePublishVolumeRequest is optional, could that be a last 
param to ensure all required are in first part?
{quote}
I prefer current order in the patch because that is align with the public CSI 
protocol, will be easier to maintain.

And your suggestion #7, allow me sometime to investigate if we can move these 
code to some DeletionTask. Thanks for the suggestion.

> [CSI] Add ability to publish/unpublish volumes on node managers
> ---------------------------------------------------------------
>
>                 Key: YARN-9038
>                 URL: https://issues.apache.org/jira/browse/YARN-9038
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Major
>              Labels: CSI
>         Attachments: YARN-9038.001.patch, YARN-9038.002.patch
>
>
> We need to add ability to publish volumes on node managers in staging area, 
> under NM's local dir. And then mount the path to docker container to make it 
> visible in the container.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to