[
https://issues.apache.org/jira/browse/YARN-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725488#comment-16725488
]
Hudson commented on YARN-9129:
------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15639 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/15639/])
YARN-9129. Ensure flush after printing to log plus additional cleanup. (billie:
rev 2e544dc921afeaa02e731cb273ac7776eec6e49d)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/ContainerShellWebSocket.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
> Ensure flush after printing to log plus additional cleanup
> ----------------------------------------------------------
>
> Key: YARN-9129
> URL: https://issues.apache.org/jira/browse/YARN-9129
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Eric Yang
> Priority: Major
> Fix For: 3.3.0
>
> Attachments: YARN-9129.001.patch, YARN-9129.002.patch,
> YARN-9129.003.patch
>
>
> Following up on findings in YARN-8962, I noticed the following issues in
> container-executor and main.c:
> - There seem to be some vars that are not cleaned up in container_executor:
> In run_docker else: free docker_binary
> In exec_container:
> before return INVALID_COMMAND_FILE: free docker_binary
> 3x return DOCKER_EXEC_FAILED: set exit code and goto cleanup instead
> cleanup needed before exit calls?
> - In YARN-8777 we added several fprintf(stderr calls, but the convention in
> container-executor.c appears to be fprintf(ERRORFILE followed by
> fflush(ERRORFILE).
> - There are leaks in TestDockerUtil_test_add_ports_mapping_to_command_Test.
> - There are additional places where flush is not performed after writing to
> stderr, including main.c display_feature_disabled_message. This can result in
> the client not receiving the error message if the connection is closed too
> quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
