[
https://issues.apache.org/jira/browse/YARN-5336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741786#comment-16741786
]
Vrushali C commented on YARN-5336:
----------------------------------
Thanks for the patch Sushil!
I think I might file another jira to track limiting the size of the key/value
for ALL key-value pairs being stored.
The patch looks good overall, just a few minor comments:
- I think we should rename FLOW_NAME_SIZE to FLOW_NAME_MAX_SIZE
- We can also add in a FLOW_NAME_DEFAULT_MAX_SIZE which is set to 0. And we
document that 0 indicates no restriction on the size.
- As Abhishek suggested, we can also add these to the yarn site default xml.
- Let's use Apache Commons Lang’s StringUtils.replace instead of the
String.replaceAll at L209 in TimelineUtils.java
> Limit the flow name size & consider cleanup for hex chars
> ---------------------------------------------------------
>
> Key: YARN-5336
> URL: https://issues.apache.org/jira/browse/YARN-5336
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Vrushali C
> Assignee: Sushil Ks
> Priority: Major
> Labels: YARN-5355
> Attachments: YARN-5336.001.patch
>
>
> As recommended by [~jrottinghuis] , need to add in some limit (default and
> configurable) for accepting key values to be written to the backend.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
