[ 
https://issues.apache.org/jira/browse/YARN-9150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742413#comment-16742413
 ] 

Vrushali C commented on YARN-9150:
----------------------------------

thanks [~Sushil-K-S] !
+ 1 on patch 002.

One minor comment but we can update it later.  Usually the default config 
variable names have the "DEFAULT" at the end or somewhere in the middle of the 
word. The reason is that, when someone is coding in an IDE, the dropdown would 
show the possible matches so both the config variable name and the default 
variable name show up as we start typing TIMELINE_SERVICE_SCHEMA_CREATOR... So 
we can have TIMELINE_SERVICE_SCHEMA_CREATOR_CLASS and 
TIMELINE_SERVICE_SCHEMA_CREATOR_DEFAULT_CLASS 

But I will commit this patch (in a day). We can update this later on. We also 
need to add to the documentation, we can do it as part of the YARN-9016 patch.



> Making TimelineSchemaCreator support different backends for Timeline Schema 
> Creation in ATSv2
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-9150
>                 URL: https://issues.apache.org/jira/browse/YARN-9150
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: ATSv2
>            Reporter: Sushil Ks
>            Assignee: Sushil Ks
>            Priority: Major
>         Attachments: YARN-9150.001.patch, YARN-9150.002.patch
>
>
> h3. Currently the TimelineSchemaCreator has a concrete implementation for 
> creating Timeline Schema's only for HBase, Hence creating this JIRA for 
> supporting multiple back-ends that ATSv2 can support.
> *Usage:*
>        Add the following property in *yarn-site.xml*
> {code:java}
> <!-- config required for specifying the TimelineSchemaCreator class for 
> ATSv2-->
> <property>
>  <name>yarn.timeline-service.schema-creator.class</name>
>  <value>YOUR_TIMELINE_SCHEMA_CREATOR_CLASS</value> <!-- Default is 
> org.apache.hadoop.yarn.server.timelineservice.storage.HBaseTimelineSchemaCreator-->
> </property>
> {code}
>      The Command needed to run the TimelineSchemaCreator need not be changed 
> i.e the below existing command can be used irrespective of the backend 
> configured.
> {code:java}
> bin/hadoop 
> org.apache.hadoop.yarn.server.timelineservice.storage.TimelineSchemaCreator 
> -create
> {code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to