[
https://issues.apache.org/jira/browse/YARN-9003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744202#comment-16744202
]
Jim Brennan commented on YARN-9003:
-----------------------------------
[~eyang] thanks for the patch. I have a few comments on the code:
# DockerLinuxContainerRuntime.validateContainerNetworkType()
This should print the given network string if it fails because too many
networks were specified.
This whole function would be simpler if you just start by splitting the string.
The split will return the full string if there are no commas.
# docker-util.c - check_network_config()
I don’t think we should be doing the inspect call if there is only one network
specified.
This is a change from previous code, and adds an extra docker invocation on
every container launch.
I think this function should early out if the number of network names is not
equal to 2. This should make the code after the loop much simpler.
# docker-util.c add_ports_mapping_to_command()
(nit) would be nice to extract the part of check_network_config() that does the
inspects and then maybe returns a list of network types so it can be used here
and in check_network_config().
> Support multi-homed network for docker container
> ------------------------------------------------
>
> Key: YARN-9003
> URL: https://issues.apache.org/jira/browse/YARN-9003
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Major
> Labels: docker
> Attachments: YARN-9003.001.patch, YARN-9003.002.patch,
> YARN-9003.003.patch, YARN-9003.004.patch, YARN-9003.005.patch,
> YARN-9003.006.patch, YARN-9003.007.patch, YARN-9003.008.patch,
> YARN-9003.009.patch
>
>
> Docker network can be defined as configuration properties - docker.network to
> setup docker container to connect to a specific network in YARN service.
> Docker can run multi-homed network by specifying --net=bridge
> --net=private-net. This is useful to expose small number of front end
> container and ports, while the rest of the infrastructure runs in private
> network. This task is to add support for specifying multiple docker networks
> to YARN service and docker support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
