[
https://issues.apache.org/jira/browse/YARN-9202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746708#comment-16746708
]
Eric Payne commented on YARN-9202:
----------------------------------
Thanks, [~kshukla] for the hard work on this patch. I have a couple of
high-level comments.
- I'm a little concerned about {{NodesListManager#setUnregisteredNMs}} always
adding an RMNode object with {{hostname:-1}}. I would like to make sure that
the new RMNodeImpl object is only added if a valid {{hostname:port}} node id
doesn't already exist.
- It seems that the new RMNodeImpl objects are put into the shutdown state and
then removed if the node registers or heartbeats. Instead of removing them, can
they just be reused and moved to the NEW or RUNNING state when the host
registers?
- Instead of modifying the RM, another option may be to modify the UI and REST
APIs so that they compare the list of known nodes with the include and exclude
list and construct a list of the remainder.
> RM does not track nodes that are in the include list and never register
> -----------------------------------------------------------------------
>
> Key: YARN-9202
> URL: https://issues.apache.org/jira/browse/YARN-9202
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.9.2, 3.0.3, 2.8.5
> Reporter: Kuhu Shukla
> Assignee: Kuhu Shukla
> Priority: Major
> Attachments: YARN-9202.001.patch
>
>
> The RM state machine decides to put new or running nodes in inactive state
> only past the point of either registration or being in the exclude list. This
> does not cover the case where a node is the in the include list but never
> registers and since all state changes are based on these NodeState
> transitions, having NEW nodes be listed as inactive first may help. This
> would change the semantics of how inactiveNodes are looked at today. Another
> state addition might help this case too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
