[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748066#comment-16748066
]
Peter Bacsko commented on YARN-9121:
------------------------------------
LGTM +1 (non-binding)
Consider using {{Preconditions.checkNotNull()}} in the constructors.
> Users of GpuDiscoverer.getInstance() are not possible to test as instance is
> a static field
> -------------------------------------------------------------------------------------------
>
> Key: YARN-9121
> URL: https://issues.apache.org/jira/browse/YARN-9121
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9121.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
