[
https://issues.apache.org/jira/browse/YARN-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749732#comment-16749732
]
Weiwei Yang edited comment on YARN-9116 at 1/23/19 9:55 AM:
------------------------------------------------------------
Latest patch looks good. But following checkstyle issues are introduced by this
patch, can you fix them?
{noformat}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java:460:
|| (queueVcores != UNDEFINED: '||' has incorrect indentation level 8, expected
level should be 10. [Indentation]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server
resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java:3273:
setMaxAllocation(conf, CapacitySchedulerConfiguration.ROOT,
"memory-mb=4096,vcores=2");: Line is longer than 80 characters (found 91).
[LineLength]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java:3319:
setMaxAllocation(conf, CapacitySchedulerConfiguration.ROOT,
"memory-mb=6144,vcores=2");: Line is longer than 80 characters (found 91).
[LineLength]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java:3393:
setMaxAllocation(conf, CapacitySchedulerConfiguration.ROOT, "memory-mb=" +
largerMem + ",vcores=2");: Line is longer than 80 characters (found 104).
[LineLength]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java:3402:
setMaxAllocation(conf, CapacitySchedulerConfiguration.ROOT,
"memory-mb=4096,vcores=2");: Line is longer than 80 characters (found 91).
[LineLength]
{noformat}
+1 once these minor issues are fixed.
And the UT failure {{TestResourceTrackerService}} seems unrelated, pls double
check.
Thanks
was (Author: cheersyang):
Latest patch looks good. But following checkstyle issues are introduced by this
patch, can you fix them?
{noformat}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java:460:
|| (queueVcores != UNDEFINED: '||' has incorrect indentation level 8, expected
level should be 10. [Indentation]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server
resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java:3273:
setMaxAllocation(conf, CapacitySchedulerConfiguration.ROOT,
"memory-mb=4096,vcores=2");: Line is longer than 80 characters (found 91).
[LineLength]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java:3319:
setMaxAllocation(conf, CapacitySchedulerConfiguration.ROOT,
"memory-mb=6144,vcores=2");: Line is longer than 80 characters (found 91).
[LineLength]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java:3393:
setMaxAllocation(conf, CapacitySchedulerConfiguration.ROOT, "memory-mb=" +
largerMem + ",vcores=2");: Line is longer than 80 characters (found 104).
[LineLength]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java:3402:
setMaxAllocation(conf, CapacitySchedulerConfiguration.ROOT,
"memory-mb=4096,vcores=2");: Line is longer than 80 characters (found 91).
[LineLength]
{noformat}
+1 once these minor issues are fixed.
And the UT failure seems unrelated, pls double check.
Thanks
> Capacity Scheduler: implements queue level maximum-allocation inheritance
> -------------------------------------------------------------------------
>
> Key: YARN-9116
> URL: https://issues.apache.org/jira/browse/YARN-9116
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Affects Versions: 2.7.0
> Reporter: Aihua Xu
> Assignee: Aihua Xu
> Priority: Major
> Attachments: YARN-9116.1.patch, YARN-9116.2.patch, YARN-9116.3.patch,
> YARN-9116.4.patch
>
>
> YARN-1582 adds the support of maximum-allocation-mb configuration per queue
> which is targeting to support larger container features on dedicated queues
> (larger maximum-allocation-mb/maximum-allocation-vcores for such queue) .
> While to achieve larger container configuration, we need to increase the
> global maximum-allocation-mb/maximum-allocation-vcores (e.g. 120G/256) and
> then override those configurations with desired values on the queues since
> queue configuration can't be larger than cluster configuration. There are
> many queues in the system and if we forget to configure such values when
> adding a new queue, then such queue gets default 120G/256 which typically is
> not what we want.
> We can come up with a queue-default configuration (set to normal queue
> configuration like 16G/8), so the leaf queues gets such values by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
