[
https://issues.apache.org/jira/browse/YARN-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750035#comment-16750035
]
Peter Bacsko commented on YARN-9133:
------------------------------------
Thanks for the update [~snemeth].
Minor things:
1. What's the benefit of having the test logic in a separate method like
{{testAllocationWithDocker()}} and {{testAllocationWithoutDocker()}}? Can't we
just move the logic back to the testcase?
2. If you have the capacity, it would be good to add error messages to the
different {{assert..()}} calls
> Make tests more easy to comprehend in TestGpuResourceHandler
> ------------------------------------------------------------
>
> Key: YARN-9133
> URL: https://issues.apache.org/jira/browse/YARN-9133
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9133.001.patch, YARN-9133.001.patch,
> YARN-9133.002.patch
>
>
> Tests are not quite easy to read:
> - Some more helper methods would improve readability.
> - Eliminating the boolean flag that controls if docker is used would also
> improve readability and clarity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
