[ 
https://issues.apache.org/jira/browse/YARN-6616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751752#comment-16751752
 ] 

Eric Payne commented on YARN-6616:
----------------------------------

[~Prabhu Joseph], Thanks for the hard work on this issue.

I'm sorry for changing my mind, but it seems that YARN-7088 added 
{{launchTime}} for the same purpose you are adding {{submitTime}}. So, I think 
they are the same value. Is that your understanding? Also, it seems that 
YARN-8218 was also created to solve the problem addressed by this JIRA.

If {{launchTime}} and {{submitTime}} are the same, then this fix becomes much 
simpler:
 - {{ApplicationReport}} does not need to be changed
 - No proto changes are necessary :)
 - The call to {{ApplicationReport.newinstance(...)}} in 
{{ApplicationHistoryManagerImpl#convertToApplicationReport}} could look like 
this:
{code:java}
-      trackingUrl, appHistory.getStartTime(), 0, appHistory.getFinishTime(),
+      trackingUrl, appHistory.getStartTime(), appHistory.getSubmitTime(), 
appHistory.getFinishTime(),
{code}

 - The 2 calls to {{ApplicationReport.newinstance(...)}} in 
{{ApplicationHistoryManagerOnTimelineStore#convertToApplicationReport}} could 
look like this:
{code:java}
-            state, diagnosticsInfo, null, createdTime, finishedTime,
+            state, diagnosticsInfo, null, createdTime, submitTime, 
finishedTime,
{code}

Thoughts?

> YARN AHS shows submitTime for jobs same as startTime
> ----------------------------------------------------
>
>                 Key: YARN-6616
>                 URL: https://issues.apache.org/jira/browse/YARN-6616
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.7.3
>            Reporter: Prabhu Joseph
>            Assignee: Prabhu Joseph
>            Priority: Minor
>         Attachments: 0001-YARN-6616.patch, 0002-YARN-6616.patch, 
> 0003-YARN-6616.patch, 0004-YARN-6616.patch, 0005-YARN-6616.patch, 
> 0006-YARN-6616.patch, 0007-YARN-6616.patch, 0008-YARN-6616.patch, 
> ApplicationReport.poc
>
>
> YARN AHS returns startTime value for both submitTime and startTime for the 
> jobs.  Looks the code sets the submitTime with startTime value. 
> https://github.com/apache/hadoop/blob/branch-2.7.3/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java#L80
> {code}
> curl --negotiate -u: 
> http://prabhuzeppelin3.openstacklocal:8188/ws/v1/applicationhistory/apps
> <submittedTime>1495015537574</submittedTime><startedTime>1495015537574</startedTime><finishedTime>1495016384084</finishedTime>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to