[
https://issues.apache.org/jira/browse/YARN-9186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758115#comment-16758115
]
Sunil Govindan commented on YARN-9186:
--------------------------------------
Thanks [~cheersyang] for checking CTrox driver as well. Let's test that once
the pull is merged.
1. It's makes sense to make use of driver names and configure the csi-adaptor
class. Since it's an address, do we need to know or hardcode some known address
such as ozone driver or s3 driver. I am not a big fan of this, however thought
of checking your opinion as well.
2. Since we move to v1 for CSI proto and we have a bunch of config changes,
could you please update the respective CSI.md file to provide those details.
3. Please remove some commented code from VolumeManagerImpl
4. Could we write a WARN log and continue in this case?
{code:java}
93 if (adaptorMap.containsKey(driverName)) {
94 throw new YarnException(
95 "Duplicate driver adaptor found," + " driver name: "
96 + driverName);
97 }
{code}
5.I did a quick glance to proto file and code change. Almost looks fine to me.
Thanks
> [CSI] Upgrade CSI proto to v1.0
> -------------------------------
>
> Key: YARN-9186
> URL: https://issues.apache.org/jira/browse/YARN-9186
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Critical
> Attachments: YARN-9186.01.patch
>
>
> CSI just released v1.0 proto, this is claimed as a stable release for CSI.
> This Jira is tracking the effort of updating YARN to support v1.0 (from v0.3).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
