[
https://issues.apache.org/jira/browse/YARN-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YARN-9268:
-------------------------------
Description:
Need to fix the following the class {{FpgaDevice}}:
* It implements {{Comparable}}, but not {{Comparable<FpgaDevice>}}, so we have
a raw type warning. It also returns 0 in every case. There is no natural
ordering among FPGA devices, perhaps "acl0" comes before "acl1", but this seems
too forced and unnecessary.We think this class should not implement
{{Comparable}} at all, at least not like that.
* Stores unnecessary fields: devName, busNum, temperature, power usage. For
one, these are never needed in the code. Secondly, temp and power usage changes
constantly. It's pointless to store these in this POJO.
* {{serialVersionUID}} is 1L - let's generate a number for this
* Use {{int}} instead of {{Integer}} - don't allow nulls. If major/minor
uniquely identifies the card, then let's demand them in the constructor and
don't store Integers that can be null.
was:
Need to fix the following the class FpgaDevice:
* It implements Comparable, but not Comparable<FpgaDevice>, so we have a raw
type warning. It also returns 0 in every case. There is no natural ordering
among FPGA devices, perhaps "acl0" comes before "acl1", but this seems too
forced and unnecessary.We think this class should not implement Comparable at
all, at least not like that.
* Stores unnecessary fields: devName, busNum, temperature, power usage. For
one, these are never needed in the code. Secondly, temp and power usage changes
constantly. It's pointless to store these in this POJO.
* serialVersionUID is 1L - let's generate a number for this
* Use int instead of Integer - don't allow nulls. If major/minor uniquely
identifies the card, then let's demand them in the constructor and don't store
Integers that can be null.
> Various fixes are needed in FpgaDevice
> --------------------------------------
>
> Key: YARN-9268
> URL: https://issues.apache.org/jira/browse/YARN-9268
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Peter Bacsko
> Priority: Major
>
> Need to fix the following the class {{FpgaDevice}}:
> * It implements {{Comparable}}, but not {{Comparable<FpgaDevice>}}, so we
> have a raw type warning. It also returns 0 in every case. There is no natural
> ordering among FPGA devices, perhaps "acl0" comes before "acl1", but this
> seems too forced and unnecessary.We think this class should not implement
> {{Comparable}} at all, at least not like that.
> * Stores unnecessary fields: devName, busNum, temperature, power usage. For
> one, these are never needed in the code. Secondly, temp and power usage
> changes constantly. It's pointless to store these in this POJO.
> * {{serialVersionUID}} is 1L - let's generate a number for this
> * Use {{int}} instead of {{Integer}} - don't allow nulls. If major/minor
> uniquely identifies the card, then let's demand them in the constructor and
> don't store Integers that can be null.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
