[ 
https://issues.apache.org/jira/browse/YARN-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760518#comment-16760518
 ] 

Rohith Sharma K S commented on YARN-9149:
-----------------------------------------

+1 lgtm

> yarn container -status misses logUrl when integrated with ATSv2
> ---------------------------------------------------------------
>
>                 Key: YARN-9149
>                 URL: https://issues.apache.org/jira/browse/YARN-9149
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Rohith Sharma K S
>            Assignee: Abhishek Modi
>            Priority: Major
>         Attachments: YARN-9149.001.patch, YARN-9149.002.patch, 
> YARN-9149.003.patch
>
>
> Post YARN-8303, yarn client can be integrated with ATSv2. But log url and 
> start and end time is printing data is wrong!
> {code}
> Container Report :
>       Container-Id : container_1545035586969_0001_01_000001
>       Start-Time : 0
>       Finish-Time : 0
>       State : COMPLETE
>       Execution-Type : GUARANTEED
>       LOG-URL : null
>       Host : localhost:25006
>       NodeHttpAddress : localhost:25008
>       Diagnostics :
> {code}
> # TimelineEntityV2Converter#convertToContainerReport set logUrl as *null*. 
> This need set for proper log url based on yarn.log.server.web-service.url
> # TimelineEntityV2Converter#convertToContainerReport parses start/end time 
> wrongly. Comparison should happen with entityType but below code is doing 
> entityId
> {code}
>     if (events != null) {
>       for (TimelineEvent event : events) {
>         if (event.getId().equals(
>             ContainerMetricsConstants.CREATED_IN_RM_EVENT_TYPE)) {
>           createdTime = event.getTimestamp();
>         } else if (event.getId().equals(
>             ContainerMetricsConstants.FINISHED_IN_RM_EVENT_TYPE)) {
>           finishedTime = event.getTimestamp();
>         }
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to