[
https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762669#comment-16762669
]
Antal Bálint Steinbach edited comment on YARN-9118 at 2/7/19 1:31 PM:
----------------------------------------------------------------------
Hi [~snemeth]!
Looks good to me!
I have one suggestion:
In TestGpuDiscoverer. I would not validate the exception through the error
messages. Instead create a new type of exception which contains:
* The invalid part
* optionally an error code
Do validation on those, not on the actual error message.
was (Author: bsteinbach):
Hi Szilard!
Looks good to me!
I have one suggestion:
In TestGpuDiscoverer. I would not validate the exception through the error
messages. Instead create a new type of exception which contains:
* The invalid part
* optionally an error code
Do validation on those, not on the actual error message.
> Handle issues with parsing user defined GPU devices in GpuDiscoverer
> --------------------------------------------------------------------
>
> Key: YARN-9118
> URL: https://issues.apache.org/jira/browse/YARN-9118
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9118.001.patch, YARN-9118.002.patch,
> YARN-9118.003.patch, YARN-9118.004.patch, YARN-9118.005.patch,
> YARN-9118.006.patch
>
>
> getGpusUsableByYarn has the following issues:
> - Duplicate GPU device definitions are not denied: This seems to be the
> biggest issue as it could increase the number of devices on the node if the
> device ID is defined 2 or more times.
> - An empty-string is accepted, it works like the user would not want to use
> auto-discovery and haven't defined any GPU devices: This will result in an
> empty device list, but the empty-string check is never explicitly there in
> the code, so this behavior just coincidental.
> - Number validation does not happen on GPU device IDs (separated by commas)
> Many testcases are added as the coverage was already very low.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
