[ 
https://issues.apache.org/jira/browse/YARN-9289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763259#comment-16763259
 ] 

Jonathan Hung commented on YARN-9289:
-------------------------------------

Attached 002 patch:
 * fix whitespace
 * re-add the annotation in GpuDeviceInformation. Seems the behavior in the 
original patch is not consistent, it will deserialize with the tag 
<driver_version> but serialize with <driverVersion>. So I just changed 
TestNMWebServices#testGetNMResourceInfo to check for driver_version instead of 
driverVersion.
 * Created a subclass of NMResourceInfo in TestNMWebServices instead of 
anonymous class since it doesn't seem like the annotations were inheriting 
correctly. (Also the json return types were strings and being compared against 
longs, so I parsed the json strings as longs before asserting)

> Backport YARN-7330 for GPU in UI to branch-2
> --------------------------------------------
>
>                 Key: YARN-9289
>                 URL: https://issues.apache.org/jira/browse/YARN-9289
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jonathan Hung
>            Assignee: Jonathan Hung
>            Priority: Major
>         Attachments: YARN-9289-YARN-8200.001.patch, 
> YARN-9289-YARN-8200.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to