[
https://issues.apache.org/jira/browse/YARN-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764630#comment-16764630
]
Weiwei Yang commented on YARN-9252:
-----------------------------------
Patch looks all good. I have only 2 comments
1. {{PlacementConstraintParser#parseNameSpace}}
Can we add a check here to make sure this method throws
PlacementConstraintParseException when a given namespace string is invalid?
Something like
{code:java}
if (!EnumUtils.isValidEnum(AllocationTagNamespaceType.class,
targetTag.substring(0, i))) {
throw new PlacementConstraintParseException("...");
}
{code}
2. {{TestPlacementConstraintParser#testParseAllocationTagNameSpace}}
line 537 and 538 can be removed
Thanks
> Allocation Tag Namespace support in Distributed Shell
> -----------------------------------------------------
>
> Key: YARN-9252
> URL: https://issues.apache.org/jira/browse/YARN-9252
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: distributed-shell
> Affects Versions: 3.1.1
> Reporter: Prabhu Joseph
> Assignee: Prabhu Joseph
> Priority: Major
> Attachments: YARN-9252-001.patch, YARN-9252-002.patch,
> YARN-9252-003.patch
>
>
> Distributed Shell supports placement constraint but allocation Tag Namespace
> is not honored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
