[ 
https://issues.apache.org/jira/browse/YARN-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765280#comment-16765280
 ] 

Giovanni Matteo Fumarola commented on YARN-996:
-----------------------------------------------

Thanks [~elgoiri] .

Few NITs:
 * Please correct the javadoc in {{RMWebServiceProtocol}}

* @param nodeId the node we want to retrieve the information. It is a
* PathParam.
* @param resourceOption the resource change
 * There are extra new lines in ResourceOptionInfo
 * Typo In FederationInterceptorREST

* Get the active subclusters in the fedeation.
 * I do not think this comment is correct

// Collect all the responses in parallel
NodeInfo nodeInfo = null;
 * In PassThroughRESTRequestInterceptor

return new ResourceInfo(); should be return 
getNextInterceptor.updateNodeResource
 * Typo in ResourceManagerRest

Wit the node update resource API, you can update the resources in a node.
 * I do not think these are correct:

| memory | long | The total amount of memory currently available on the node 
(in MB) |
| vcores | long | The total number of vCores currently used on the node |

> REST API support for node resource configuration
> ------------------------------------------------
>
>                 Key: YARN-996
>                 URL: https://issues.apache.org/jira/browse/YARN-996
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: graceful, nodemanager, scheduler
>            Reporter: Junping Du
>            Assignee: Tsuyoshi Ozawa
>            Priority: Major
>         Attachments: YARN-996-10.patch, YARN-996-2.patch, YARN-996-3.patch, 
> YARN-996-4.patch, YARN-996-5.patch, YARN-996-6.patch, YARN-996-7.patch, 
> YARN-996-8.patch, YARN-996-9.patch, YARN-996-sample.patch
>
>
> Besides admin protocol and CLI, REST API should also be supported for node 
> resource configuration



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to