[ 
https://issues.apache.org/jira/browse/YARN-8927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766636#comment-16766636
 ] 

Zhankun Tang edited comment on YARN-8927 at 2/13/19 1:35 AM:
-------------------------------------------------------------

[~eyang], [~ebadger] Thanks for the review!

If a local image name contains "/" in it, it may not be considered as 
"top-level" image.

It seems if a user wants lcoal image "repoA/userA/imageA" to be allowed, he/she 
should configure "repoA/userA" in the "docker.trusted.registries"? I will try 
if this works and get back to you.

And one thing worthing noting is that if YARN allow an image name, then Docker 
will check if it's local and prefer to run it.


was (Author: tangzhankun):
[~eyang], [~ebadger] Thanks for the review!

If a local image name contains "/" in it, it may not be considered as 
"top-level" image.

It seems if a user wants lcoal image "repoA/userA/imageA" to be allowed, he/she 
should configure "repoA/userA" in the "docker.trusted.registries"? I will try 
if this works and get back to you.

> Support trust top-level image like "centos" when "library" is configured in 
> "docker.trusted.registries"
> -------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-8927
>                 URL: https://issues.apache.org/jira/browse/YARN-8927
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Zhankun Tang
>            Assignee: Zhankun Tang
>            Priority: Major
>              Labels: Docker
>         Attachments: YARN-8927-trunk.001.patch, YARN-8927-trunk.002.patch
>
>
> There are some missing cases that we need to catch when handling 
> "docker.trusted.registries".
> The container-executor.cfg configuration is as follows:
> {code:java}
> docker.trusted.registries=tangzhankun,ubuntu,centos{code}
> It works if run DistrubutedShell with "tangzhankun/tensorflow"
> {code:java}
> "yarn ... -shell_env YARN_CONTAINER_RUNTIME_TYPE=docker -shell_env 
> YARN_CONTAINER_RUNTIME_DOCKER_IMAGE=tangzhankun/tensorflow
> {code}
> But run a DistrubutedShell job with "centos", "centos[:tagName]", "ubuntu" 
> and "ubuntu[:tagName]" fails:
> The error message is like:
> {code:java}
> "image: centos is not trusted"
> {code}
> We need better handling the above cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to