[
https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767263#comment-16767263
]
Peter Bacsko edited comment on YARN-9138 at 2/13/19 2:47 PM:
-------------------------------------------------------------
[~snemeth]
1. now you can remove these unnecessary code-paths:
{noformat}
if (Shell.WINDOWS) {
...
} else {
...
{noformat}
2. OK, I know this is annoying, but could you static import assert calls? We
use it everywhere else, so let's be consistent.
3. String "PATH" is used multiple times, it's worth making it static final.
Same applies to "u+x".
was (Author: pbacsko):
[~snemeth] now you can remove these unnecessary code-paths:
{noformat}
if (Shell.WINDOWS) {
...
} else {
...
{noformat}
> Test error handling of nvidia-smi binary execution of GpuDiscoverer
> -------------------------------------------------------------------
>
> Key: YARN-9138
> URL: https://issues.apache.org/jira/browse/YARN-9138
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9138.001.patch, YARN-9138.002.patch
>
>
> The code that executes nvidia-smi (doing GPU device auto-discovery) don't
> have much test coverage.
> This patch adds tests to this part of the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
