[
https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767291#comment-16767291
]
Peter Bacsko commented on YARN-9123:
------------------------------------
" testGetNMResourceInfoFailBecauseOfUnknownPlugin is a bit lengthy: 47
character."
I think this is fine (seen much worse). Another name could be sth like
{{testGetNMResourceInfoWhenPluginIsUnknown}} which is also a popular naming
scheme (I mean using "when").
Talking about repetitions, this could be extracted too:
{noformat}
ClientResponse response = r.path("ws").path("v1").path("node").path(
"resources").path("resource-2").accept(MediaType.APPLICATION_JSON).get(
ClientResponse.class);
{noformat}
> Clean up and split testcases in TestNMWebServices for GPU support
> -----------------------------------------------------------------
>
> Key: YARN-9123
> URL: https://issues.apache.org/jira/browse/YARN-9123
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-9123.001.patch, YARN-9123.002.patch,
> YARN-9123.003.patch, YARN-9123.004.patch
>
>
> The following testcases can be cleaned up a bit:
> TestNMWebServices#testGetNMResourceInfo - Can be split up to 3 different cases
> TestNMWebServices#testGetYarnGpuResourceInfo
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
