[
https://issues.apache.org/jira/browse/YARN-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767300#comment-16767300
]
Szilard Nemeth commented on YARN-9118:
--------------------------------------
Hi [~tangzhankun]!
Fixed some of the checkstyle issues with patch008.
Some of them does not make sense for me:
- Missing package-info: Is this really required?
- I had 2 lines are longer than 80 chars issues in
GpuDeviceSpecificationException: If I put those method names into a newline, it
looks really weird.
- 'conf' hides a field: Does this have any value to rename the parameter?
Are you fine with not fixing the issues listed above?
[~pbacsko]: Extracted the creation of the configuration objects into the method
with the latest patch.
> Handle issues with parsing user defined GPU devices in GpuDiscoverer
> --------------------------------------------------------------------
>
> Key: YARN-9118
> URL: https://issues.apache.org/jira/browse/YARN-9118
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9118.001.patch, YARN-9118.002.patch,
> YARN-9118.003.patch, YARN-9118.004.patch, YARN-9118.005.patch,
> YARN-9118.006.patch, YARN-9118.007.patch, YARN-9118.008.patch
>
>
> getGpusUsableByYarn has the following issues:
> - Duplicate GPU device definitions are not denied: This seems to be the
> biggest issue as it could increase the number of devices on the node if the
> device ID is defined 2 or more times.
> - An empty-string is accepted, it works like the user would not want to use
> auto-discovery and haven't defined any GPU devices: This will result in an
> empty device list, but the empty-string check is never explicitly there in
> the code, so this behavior just coincidental.
> - Number validation does not happen on GPU device IDs (separated by commas)
> Many testcases are added as the coverage was already very low.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
