[
https://issues.apache.org/jira/browse/YARN-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768097#comment-16768097
]
Szilard Nemeth commented on YARN-9139:
--------------------------------------
[~pbacsko]: Thanks for the review comments, once again!
1. Fixed
2. It was a copy-paste issue, I fixed it
3. This is somewhat a personal coding style preference. I like to create /
initialize the objects with helper methods and invoke them from the testcases
instead of fields and I tent to use fields for heavier objects. I guess you are
fine with not modifying this one.
> Simplify initializer code of GpuDiscoverer
> ------------------------------------------
>
> Key: YARN-9139
> URL: https://issues.apache.org/jira/browse/YARN-9139
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9139.001.patch, YARN-9139.002.patch,
> YARN-9139.003.patch, YARN-9139.004.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
